Expose ContextAndRuleProviderState, IProjectState, and QueryProjectPropertiesContext to Support JSPS Launch Profiles UI #9621
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emfisch
force-pushed
the
dev/emilyfischer/launchJsonUI
branch
from
800e1b0 to
f22999a
Compare
drewnoakes
added
the
Feature-Debugging
|
LGTM. Have asked @tmeschter to take a look in case he has any concerns, as he wrote this originally. |
|
@dotnet-policy-service agree company="Microsoft" |
tmeschter
approved these changes
Dec 13, 2024
drewnoakes
approved these changes
Dec 13, 2024
drewnoakes
pushed a commit
that referenced
this pull request
Feb 3, 2025
…ers (#9641) This is a follow up to these PRs: #9621, #9631 The TypeScript/JavaScript team is working on adding a version of the launch profiles UI that reads/writes from` launch.json `rather than` launchsettings.json`. We'd like reuse dotnet's existing functionality for this, with the exception of actions specific to modifying ` launchsettings.json`. With this PR, all actions specific to ` launchsettings.json` have been moved into a separate class (`LaunchProfileProjectActionProvider`) with relevant filtering `([AppliesTo(ProjectCapability.DotNet)])`. I have removed this filtering from the other action providers so they can be used for JSPS projects as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TS/JS team would like to add a version of the launch profiles UI for JSPS projects that reads/writes from
launch.jsonrather thanlaunchsettings.json. By makingContextAndRuleProviderState,IProjectState, andQueryProjectPropertiesContextpublic, we can reuse several of the QueryDataProviders dotnet has already implemented to populate the launch profiles UI.For example, the UIPropertyFromRuleDataProducer class is expecting context of the type
ContextAndRuleProviderState, and I would like this class to populate UI properties for the JSPS scenario as well.I have already confirmed that these changes will allow the launch.json UI to work properly:
Microsoft Reviewers: Open in CodeFlow